Skip to content

pubsub: add getAttributes for gcp pubsub #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

pubsub: add getAttributes for gcp pubsub #109

wants to merge 17 commits into from
+1,225 −18

Conversation

@LihaoLiuXs
Copy link
Collaborator

Summary

Some conventions to follow

  1. add the module name as a prefix
  • for example: if your change is for blob store, add a prefix: docstore: for document store module, blobstore for Blob Store module
  1. for a test only PR, add test:
  2. for a perf improvement only PR, add perf:

@sandeepvinayak sandeepvinayak changed the title Sync getAttributes api to open source repo pubsub: sync getAttributes api to open source repo Oct 27, 2025
@sandeepvinayak sandeepvinayak changed the title pubsub: sync getAttributes api to open source repo pubsub: add getAttributes for gcp pubsub Oct 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.45%. Comparing base (581005b) to head (2b8d6ee).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../multicloudj/pubsub/client/GetAttributeResult.java 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #109      +/-   ##
============================================
+ Coverage     78.19%   82.45%   +4.25%     
============================================
  Files           136      137       +1     
  Lines          7036     7068      +32     
  Branches        801      804       +3     
============================================
+ Hits           5502     5828     +326     
+ Misses         1112      823     -289     
+ Partials        422      417       -5
Flag Coverage Δ
unittests 82.45% <89.47%> (+4.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LihaoLiuXs @codecov-commenter